[Server] Extend elicitation enum schema compliance#261
Open
chr-hertel wants to merge 1 commit intomainfrom
Open
[Server] Extend elicitation enum schema compliance#261chr-hertel wants to merge 1 commit intomainfrom
chr-hertel wants to merge 1 commit intomainfrom
Conversation
chr-hertel
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PHP MCP conformance server and schema layer to support extended elicitation enum schemas (SEP-1330) and defaults (SEP-1034), aligning with upstream conformance expectations.
Changes:
- Add new conformance tools to exercise server-initiated elicitation, defaults, and enum-schema variants.
- Introduce new elicitation schema definition classes for SEP-1330 titled enums and multi-select enums.
- Remove previously-listed elicitation checks from the conformance expected-failures baseline.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Conformance/server.php | Registers new conformance tools for elicitation scenarios. |
| tests/Conformance/Elements.php | Implements tool handlers that send elicitation requests with defaults and enum schemas. |
| tests/Conformance/conformance-baseline.yml | Drops elicitation checks from expected failures (implying they now pass). |
| src/Schema/Elicitation/ElicitationSchema.php | Broadens properties PHPDoc type to AbstractSchemaDefinition. |
| src/Schema/Elicitation/TitledEnumSchemaDefinition.php | Adds SEP-1330 single-select titled enum schema serialization. |
| src/Schema/Elicitation/MultiSelectEnumSchemaDefinition.php | Adds multi-select enum schema serialization. |
| src/Schema/Elicitation/TitledMultiSelectEnumSchemaDefinition.php | Adds SEP-1330 multi-select titled enum schema serialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chr-hertel
force-pushed
the
elicit-schema
branch
2 times, most recently
from
a76141b to
8eaeef3
Compare
chr-hertel
added
the
improves spec compliance
chr-hertel
force-pushed
the
elicit-schema
branch
from
e1270dc to
65541ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackling extended elicitations schema of modelcontextprotocol/modelcontextprotocol#1330 and conformance tests.
Also fixes #178